Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality: Use FileExtensionHelpers more widely #10846

Merged
merged 7 commits into from
Dec 26, 2022
Merged

Code quality: Use FileExtensionHelpers more widely #10846

merged 7 commits into from
Dec 26, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 26, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from QuaintMako December 26, 2022 21:34
yaira2
yaira2 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement to the code, LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 26, 2022
@yaira2 yaira2 merged commit 835ba6e into files-community:main Dec 26, 2022
@gave92 gave92 deleted the issue_10831 branch December 26, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@QuaintMako QuaintMako Awaiting requested review from QuaintMako

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use FileExtensionHelpers more widely
3 participants
@gave92 @yaira2 @0x5bfa