Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where Alt-Up focused on the column header #10633

Merged
merged 19 commits into from
Jan 8, 2023
Merged

Fix: Fixed issue where Alt-Up focused on the column header #10633

merged 19 commits into from
Jan 8, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Dec 5, 2022 •
edited by gave92
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Dec 5, 2022

Can you share a screen recording of the new behavior?

@ferrariofilippo
Copy link
Contributor Author

Here it is

Files.mov

@yaira2
Copy link
Member

yaira2 commented Dec 5, 2022

Is it selecting the "Name" column header now?

@QuaintMako
Copy link
Contributor

Is it selecting the "Name" column header now?

The Name header selection is probably a side effect of #10439. The detailed view focused first the header while the view is loading the items, and then the first element.

@yaira2
Copy link
Member

yaira2 commented Dec 6, 2022

What's the best path forward here?

@QuaintMako
Copy link
Contributor

An idea I cannot test for now, we may get away with a proper unfocus on line 449 in src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs.

Feels like a makeshift solution though.

@yaira2
Copy link
Member

yaira2 commented Dec 7, 2022

The focus is set correctly when clicking the toolbar buttons, can we try to replicate this with the shortcuts?

@ferrariofilippo
Copy link
Contributor Author

@yaira2 @QuaintMako
I fixed the focus problem. Basically, the issue was that FileList had IsTabStop set to false for some reason when it should default to true.
Can you tell me if now it's working as intended?

@ferrariofilippo ferrariofilippo force-pushed the Fixed_Alt_Up_Focuses_On_The_Tab branch from 9cd8121 to 6393542 Compare December 17, 2022 12:44
@ferrariofilippo
Copy link
Contributor Author

@yaira2 do you know how to fix the problem with the pipeline?

@yaira2 yaira2 changed the title Fixed: Alt-Up focuses on the tab Fix: Fixed issue where Alt-Up focused on the column header Dec 18, 2022
@yaira2
Copy link
Member

yaira2 commented Dec 18, 2022

The behavior is better but it still doesn't match the behavior when clicking the up button in the toolbar.

@ferrariofilippo
Copy link
Contributor Author

The behavior is better but it still doesn't match the behavior when clicking the up button in the toolbar.

Can you tell me more about this?

@yaira2
Copy link
Member

yaira2 commented Dec 18, 2022 •
edited
Loading

Notice the black rectangle as the focus changes

@ferrariofilippo
Copy link
Contributor Author

With the latest commit the bug is almost fixed (occurs in < 1/10). I don't think it can be 100% fixed, since you can't focus on specific items, but you need to focus the ListView.

@yaira2 yaira2 requested a review from gave92 December 21, 2022 20:33
@yaira2 yaira2 requested review from gave92 and yaira2 December 28, 2022 05:07
@gave92
Copy link
Member

gave92 commented Jan 6, 2023

@yaira2 could you test with the latest changes if focus behaviour is good?

yaira2
yaira2 approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 8, 2023
@yaira2 yaira2 merged commit e1c4c3b into files-community:main Jan 8, 2023
@ferrariofilippo ferrariofilippo deleted the Fixed_Alt_Up_Focuses_On_The_Tab branch January 8, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@gave92 gave92 Awaiting requested review from gave92

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Right click menu doesn't work on path bar Bug: Alt-up focuses on the tab
4 participants
@ferrariofilippo @yaira2 @QuaintMako @gave92