Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : ETH RPC API: eth subscribe tipsets API should only return tipse… #6351

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

simlecode
Copy link
Collaborator

…ts that have been executed

关联的Issues (Related Issues)

pr: 11858

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 26%. Comparing base (92c5a10) to head (73bd245).
Report is 4 commits behind head on feat/nv23.

Additional details and impacted files
@@            Coverage Diff            @@
##           feat/nv23   #6351   +/-   ##
=========================================
- Coverage         26%     26%   -1%     
=========================================
  Files            649     649           
  Lines          65537   65548   +11     
=========================================
- Hits           17085   17078    -7     
- Misses         45733   45747   +14     
- Partials        2719    2723    +4     

@simlecode simlecode merged commit a469ae5 into feat/nv23 Jun 13, 2024
3 checks passed
@simlecode simlecode deleted the fix/eth-subscribe-off-by-1 branch June 13, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants