Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: use bin_name #6240

Merged
merged 2 commits into from
Dec 4, 2023
Merged

opt: use bin_name #6240

merged 2 commits into from
Dec 4, 2023

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Nov 30, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

droplet 需要合并 droplet 和 droplet-client 后打包上传到 ftp 服务器,但由于打包后的文件过大会导致上传不上去,所以分别上传

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode force-pushed the opt/compress-release branch from 19f5a9c to 5b12304 Compare December 4, 2023 02:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Merging #6240 (e926936) into master (3fb279c) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6240   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         636     636           
  Lines       78063   78063           
======================================
+ Hits        20216   20224    +8     
+ Misses      55181   55172    -9     
- Partials     2666    2667    +1     

@simlecode simlecode changed the title opt: compress release opt: use bin_name Dec 4, 2023
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 99d1a39 into master Dec 4, 2023
3 checks passed
@LinZexiao LinZexiao deleted the opt/compress-release branch December 4, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants