Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/pick 10971,10955,10934 from lotus #6078

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

LinZexiao
Copy link
Collaborator

关联的Issues (Related Issues)

close #6018
close #6020
close #6021

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao requested a review from simlecode July 24, 2023 08:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #6078 (c6e249e) into master (cce79d1) will increase coverage by 0%.
The diff coverage is 71%.

❗ Current head c6e249e differs from pull request most recent head 3cdf0b9. Consider uploading reports for the commit 3cdf0b9 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6078   +/-   ##
======================================
  Coverage      24%     24%           
======================================
  Files         661     662    +1     
  Lines       80226   80270   +44     
======================================
+ Hits        19653   19676   +23     
- Misses      57973   57992   +19     
- Partials     2600    2602    +2     

@LinZexiao LinZexiao force-pushed the chore/pick-10971,10955,10934-from-lotus branch from c6e249e to 3cdf0b9 Compare July 25, 2023 10:07
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 643bb04 into master Jul 28, 2023
@simlecode simlecode deleted the chore/pick-10971,10955,10934-from-lotus branch July 28, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants