Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: market: rename OfflineDealImport to DealsImport #6012

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

#5943

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode force-pushed the refactor/import-deal branch from 18ad821 to d8ba39c Compare June 9, 2023 03:05
@codecov-commenter
Copy link

Codecov Report

Merging #6012 (18ad821) into master (34720ee) will decrease coverage by 1%.
The diff coverage is 0%.

❗ Current head 18ad821 differs from pull request most recent head d8ba39c. Consider uploading reports for the commit d8ba39c to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6012   +/-   ##
======================================
- Coverage      24%     24%   -1%     
======================================
  Files         659     659           
  Lines       79958   79958           
======================================
- Hits        19646   19642    -4     
- Misses      57713   57716    +3     
- Partials     2599    2600    +1     

@hunjixin hunjixin merged commit 3aa830e into master Jun 12, 2023
@hunjixin hunjixin deleted the refactor/import-deal branch June 12, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants