Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: DealsImportData adds parameter skipCommP #5898

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Apr 11, 2023

关联的Issues (Related Issues)

#5899

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Apr 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5898 (9bdbbf9) into master (4beae95) will decrease coverage by 1%.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5898   +/-   ##
======================================
- Coverage      24%     24%   -1%     
======================================
  Files         642     642           
  Lines       77806   77806           
======================================
- Hits        19405   19399    -6     
- Misses      55815   55822    +7     
+ Partials     2586    2585    -1     

@hunjixin hunjixin merged commit 1e2ffb9 into master Apr 11, 2023
@hunjixin hunjixin deleted the opt/market/import-data branch April 11, 2023 09:13
@elvin-du
Copy link
Collaborator

DealsImportData这个接口改了对吧?和以前的这个接口兼容吗?

@simlecode
Copy link
Collaborator Author

不兼容

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants