Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick #5832 #5870

Merged
merged 1 commit into from
Mar 29, 2023
Merged

chore: cherry pick #5832 #5870

merged 1 commit into from
Mar 29, 2023

Conversation

simlecode
Copy link
Collaborator

Chore/transport code

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #5870 (df25073) into release/v1.10 (8babb9c) will increase coverage by 0%.
The diff coverage is 17%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/v1.10   #5870   +/-   ##
=============================================
  Coverage             24%     24%           
=============================================
  Files                642     643    +1     
  Lines              77922   77976   +54     
=============================================
+ Hits               19357   19378   +21     
- Misses             55983   56014   +31     
- Partials            2582    2584    +2     

@simlecode simlecode self-assigned this Mar 29, 2023
@simlecode simlecode requested a review from diwufeiwen March 29, 2023 08:02
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 681aedf into release/v1.10 Mar 29, 2023
@diwufeiwen diwufeiwen deleted the chore/pick-5832 branch March 29, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants