Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make chain tipset fetching 1000x faster #5824

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Mar 14, 2023

关联的Issues (Related Issues)

close #5814

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen self-assigned this Mar 14, 2023
simlecode
simlecode previously approved these changes Mar 14, 2023
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diwufeiwen diwufeiwen force-pushed the opt/lt/fast_chain_index branch 2 times, most recently from d773702 to 3766eef Compare March 15, 2023 08:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #5824 (3766eef) into master (73746ce) will decrease coverage by 1%.
The diff coverage is 51%.

❗ Current head 3766eef differs from pull request most recent head 02acbd9. Consider uploading reports for the commit 02acbd9 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5824   +/-   ##
======================================
- Coverage      24%     24%   -1%     
======================================
  Files         642     642           
  Lines       77685   77690    +5     
======================================
- Hits        19383   19378    -5     
- Misses      55718   55726    +8     
- Partials     2584    2586    +2     

@diwufeiwen diwufeiwen force-pushed the opt/lt/fast_chain_index branch from 3766eef to 2b25b21 Compare March 16, 2023 01:17
@diwufeiwen diwufeiwen force-pushed the opt/lt/fast_chain_index branch from 2b25b21 to 02acbd9 Compare March 16, 2023 02:14
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 511f1bd into master Mar 16, 2023
@simlecode simlecode deleted the opt/lt/fast_chain_index branch March 16, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[venus] chain fetch faster / chain fetch 优化
3 participants