-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tanlang/wallet add sign recorder #5751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinZexiao
force-pushed
the
feat/tanlang/wallet-add-sign-recorder
branch
from
February 23, 2023 07:25
a225c71
to
aa47b88
Compare
simlecode
reviewed
Feb 23, 2023
hunjixin
reviewed
Feb 23, 2023
LinZexiao
force-pushed
the
feat/tanlang/wallet-add-sign-recorder
branch
from
February 27, 2023 07:25
a219433
to
4354d91
Compare
simlecode
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5751 +/- ##
=======================================
Coverage 25% 25%
=======================================
Files 639 639
Lines 76583 76276 -307
=======================================
+ Hits 19421 19429 +8
+ Misses 54562 54251 -311
+ Partials 2600 2596 -4 |
simlecode
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
ref #5725
改动 (Proposed Changes)
附注 (Additional Info)
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that: