Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tanlang/unify auth client #5196

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Aug 17, 2022

关联的Issues (Related Issues)

involve #5193

改动 (Proposed Changes)

  • update venus-auth/jwtclient
  • replace pkg/jwtauth with venus-auth/jwtclient
  • remove pkg/jwtauth

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao force-pushed the feat/tanlang/unify-Auth-client branch from ca7425b to f1adb30 Compare August 18, 2022 07:02
@LinZexiao LinZexiao requested a review from hunjixin August 19, 2022 08:43
app/node/test/builder.go Outdated Show resolved Hide resolved
app/node/test/builder.go Outdated Show resolved Hide resolved
@LinZexiao LinZexiao requested a review from hunjixin August 23, 2022 01:31
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #5196 (73356bf) into master (64c38fa) will decrease coverage by 0%.
The diff coverage is 25%.

@@          Coverage Diff           @@
##           master   #5196   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         592     590    -2     
  Lines       65383   65319   -64     
======================================
- Hits        16387   16364   -23     
+ Misses      46852   46814   -38     
+ Partials     2144    2141    -3     

@hunjixin hunjixin merged commit 0264e85 into master Aug 24, 2022
@hunjixin hunjixin deleted the feat/tanlang/unify-Auth-client branch August 24, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants