Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tanlang/add api to manager p2p net in meassager #5185

Merged

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Aug 15, 2022

关联的Issues (Related Issues)

involve #5129

改动 (Proposed Changes)

  • move genesis sub module from /fixtures/networks to pkg/genesis
  • add api to manager p2p net in masssager

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

from fixtures/networks
to tools/gengen/util
NetFindPeer
NetPeers
NetConnect
@LinZexiao LinZexiao requested a review from simlecode August 15, 2022 03:24
fixtures/networks/api.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #5185 (a42a202) into master (15088ed) will increase coverage by 0%.
The diff coverage is 23%.

@@          Coverage Diff           @@
##           master   #5185   +/-   ##
======================================
  Coverage      24%     25%           
======================================
  Files         592     592           
  Lines       65338   65383   +45     
======================================
+ Hits        16306   16386   +80     
+ Misses      46889   46852   -37     
- Partials     2143    2145    +2     

venus-shared/api/messager/api.go Show resolved Hide resolved
tools/gengen/util/generator.go Outdated Show resolved Hide resolved
fixtures/networks/api.go Outdated Show resolved Hide resolved
@LinZexiao LinZexiao force-pushed the feat/tanlang/add-api-to-manager-p2p-net-in-meassager branch from 664475c to 5c3b21b Compare August 15, 2022 07:38
@LinZexiao LinZexiao force-pushed the feat/tanlang/add-api-to-manager-p2p-net-in-meassager branch from 5c3b21b to a42a202 Compare August 15, 2022 07:41
@LinZexiao LinZexiao requested a review from simlecode August 15, 2022 08:05
@LinZexiao LinZexiao self-assigned this Aug 15, 2022
@LinZexiao LinZexiao requested a review from zl03jsj August 15, 2022 08:15
@simlecode simlecode merged commit 64c38fa into master Aug 15, 2022
@simlecode simlecode deleted the feat/tanlang/add-api-to-manager-p2p-net-in-meassager branch August 15, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants