Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix missing secrets #5175

Merged
merged 1 commit into from
Aug 9, 2022
Merged

ci: fix missing secrets #5175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build_upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,13 @@ jobs:
with:
bin_name: 'venus'
has_ffi: true
secrets:
OSS_KEY_ID: ${{secrets.OSS_KEY_ID}}
OSS_KEY_SECRET: ${{secrets.OSS_KEY_SECRET}}
OSS_ENDPOINT: ${{secrets.OSS_ENDPOINT}}
OSS_BUCKET: ${{secrets.OSS_BUCKET}}
FTP_HOST: ${{secrets.FTP_HOST}}
FTP_USER: ${{secrets.FTP_USER}}
FTP_PWD: ${{secrets.FTP_PWD}}
GODEYE_URL: ${{secrets.GODEYE_URL}}
token: ${{github.token}}
17 changes: 16 additions & 1 deletion .github/workflows/common_build_upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,21 @@ on:
type: string
has_ffi:
type: boolean
secrets:
OSS_KEY_ID:
OSS_KEY_SECRET:
OSS_ENDPOINT:
OSS_BUCKET:
FTP_HOST:
required: true
FTP_USER:
required: true
FTP_PWD:
required: true
GODEYE_URL:
required: true
token:
required: true

jobs:

Expand Down Expand Up @@ -145,7 +160,7 @@ jobs:
artifacts: ${{steps.vars.outputs.artifact_name}}
tag: ${{ steps.vars.outputs.github_tag }}
commit: ${{ steps.vars.outputs.commit }}
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.token }}

- name: upload ftp
id: uploadftp
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/common_docker_image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: Reuse Docker Image CI
on:

workflow_call:
secrets:
DOCKER_PASSWORD:
required: true

jobs:

Expand Down Expand Up @@ -37,6 +40,7 @@ jobs:
echo github_tag = ${{ steps.vars.outputs.github_tag }}
echo repo_name = ${{ steps.vars.outputs.repo_name }}
echo docker_user_name = ${{steps.vars.outputs.docker_user_name}}
echo docker_password = ${{secrets.DOCKER_PASSWORD}}

- name: Build the Docker image
if: ${{ steps.vars.outputs.is_tag_create == 'true' }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docker_image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ jobs:

build_docker_image:
uses: ./.github/workflows/common_docker_image.yml
secrets:
DOCKER_PASSWORD: ${{secrets.DOCKER_PASSWORD}}