Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 修改增加s3piecestorage的market接口 / fix interface which add s3piecestorage #5153

Merged

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Aug 3, 2022

关联的Issues (Related Issues)

involve #5069

改动 (Proposed Changes)

fix interface which add s3piecestorage
fix structure which transpor info about s3piecestorage

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao self-assigned this Aug 3, 2022
@LinZexiao LinZexiao requested a review from hunjixin August 3, 2022 06:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #5153 (2d83fc4) into master (f5a4cc0) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #5153   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         596     597    +1     
  Lines       65521   65586   +65     
======================================
+ Hits        16543   16547    +4     
- Misses      46816   46876   +60     
- Partials     2162    2163    +1     

@LinZexiao LinZexiao requested a review from simlecode August 5, 2022 01:51
@LinZexiao LinZexiao force-pushed the feat/tanlang/fix-interface-which-add-s3piecestorage branch from 4891fca to 62144a9 Compare August 5, 2022 01:55
simlecode
simlecode previously approved these changes Aug 5, 2022
@LinZexiao LinZexiao force-pushed the feat/tanlang/fix-interface-which-add-s3piecestorage branch from 62144a9 to a09788f Compare August 5, 2022 08:13
hunjixin
hunjixin previously approved these changes Aug 5, 2022
Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao force-pushed the feat/tanlang/fix-interface-which-add-s3piecestorage branch from a09788f to 2859e2e Compare August 5, 2022 09:16
and interface to add s3 piecestorage
@LinZexiao LinZexiao force-pushed the feat/tanlang/fix-interface-which-add-s3piecestorage branch from 2859e2e to 2d83fc4 Compare August 5, 2022 10:00
@hunjixin hunjixin merged commit f63fbca into master Aug 9, 2022
@hunjixin hunjixin deleted the feat/tanlang/fix-interface-which-add-s3piecestorage branch August 9, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants