-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change PR template #5123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5123 +/- ##
======================================
Coverage 25% 25%
======================================
Files 596 596
Lines 65485 65485
======================================
+ Hits 16591 16594 +3
+ Misses 46727 46726 -1
+ Partials 2167 2165 -2 |
其中 "包含必要的测试用例", "包含必要的指南或文档" 从语义上来说是本次 PR 包含测试用例和文档才需要勾选,但我觉得这两个改成检查项 "包含必要的测试用例或不需要", "包含必要的指南或文档或不需要",可能更加符合 “自查清单“。 参考案例: ant-design PULL_REQUEST_TEMPLATE CN, ant-design PULL_REQUEST_TEMPLATE EN |
5191493
to
e5b7692
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
前面提的建议尽快处理后合并,用起来!
小的空格问题。 |
remove blank space Co-authored-by: Yu <[email protected]>
remove blank space Co-authored-by: Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issues
involve #4971
Proposed Changes
change PR template
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <#issue number> <area>: <change being made>
fix: #1234 mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, testarea
: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet