Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add UpgradeSkyrHeight field to StateGetNetworkParams #5103

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

simlecode
Copy link
Collaborator

Related Issues

fix: #5027

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@simlecode simlecode requested a review from diwufeiwen July 19, 2022 01:50
@codecov-commenter
Copy link

Codecov Report

Merging #5103 (82a3df8) into master (a58ab9f) will increase coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #5103   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         596     596           
  Lines       65500   65501    +1     
======================================
+ Hits        16578   16583    +5     
+ Misses      46754   46750    -4     
  Partials     2168    2168           

@diwufeiwen diwufeiwen merged commit a086a8a into master Jul 19, 2022
@diwufeiwen diwufeiwen deleted the fix/miss_skyr_height branch July 19, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[venus] StateGetNetworkParams 接口返回结果未包含 nv16 的升级高度
3 participants