Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: issue template update #5078

Merged
merged 16 commits into from
Jul 20, 2022
Merged

Chore: issue template update #5078

merged 16 commits into from
Jul 20, 2022

Conversation

Fatman13
Copy link
Contributor

Related Issues

resolve #5077

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@Fatman13 Fatman13 added the C-docs Category: Documentation label Jul 13, 2022
@Fatman13 Fatman13 changed the title Fatman13 p Chore: issue template update Jul 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #5078 (9abd13a) into master (52c7ad2) will increase coverage by 0%.
The diff coverage is n/a.

❗ Current head 9abd13a differs from pull request most recent head c58d7d9. Consider uploading reports for the commit c58d7d9 to get more accurate results

@@          Coverage Diff           @@
##           master   #5078   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         597     597           
  Lines       65079   65079           
======================================
+ Hits        16566   16568    +2     
+ Misses      46349   46348    -1     
+ Partials     2164    2163    -1     

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit比较多,合并前最好整理下

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatman13 Fatman13 merged commit 0eb50c5 into master Jul 20, 2022
@Fatman13 Fatman13 deleted the fatman13-p branch July 20, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs Category: Documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

github issue template update
4 participants