Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename repodir to repo #5070

Merged
merged 2 commits into from
Jul 13, 2022
Merged

fix: rename repodir to repo #5070

merged 2 commits into from
Jul 13, 2022

Conversation

simlecode
Copy link
Collaborator

Related Issues

resolve: #4964

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@simlecode simlecode requested a review from hunjixin July 12, 2022 09:08
@simlecode simlecode requested a review from diwufeiwen July 13, 2022 01:26
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit eba940a into master Jul 13, 2022
@diwufeiwen diwufeiwen deleted the fix/rename_repodir_to_repo branch July 13, 2022 02:33
@Fatman13
Copy link
Contributor

保持兼容性很好。👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[建议] REPO dir 环境变量名称和 CLI 参数名称保持一致
3 participants