Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add NetDisconnect api #5026

Merged
merged 1 commit into from
Jul 8, 2022
Merged

api: add NetDisconnect api #5026

merged 1 commit into from
Jul 8, 2022

Conversation

simlecode
Copy link
Collaborator

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #5026 (b550a47) into master (d8da353) will decrease coverage by 0%.
The diff coverage is 0%.

❗ Current head b550a47 differs from pull request most recent head c57d3d8. Consider uploading reports for the commit c57d3d8 to get more accurate results

@@          Coverage Diff           @@
##           master   #5026   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         597     597           
  Lines       65042   65055   +13     
======================================
- Hits        16575   16571    -4     
- Misses      46305   46322   +17     
  Partials     2162    2162           

@simlecode simlecode requested a review from hunjixin July 5, 2022 00:56
@simlecode simlecode force-pushed the api/add-netdisconnect branch 2 times, most recently from a4ac2e5 to b550a47 Compare July 8, 2022 03:07
@simlecode simlecode force-pushed the api/add-netdisconnect branch from b550a47 to c57d3d8 Compare July 8, 2022 09:41
Copy link
Contributor

@zl03jsj zl03jsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ITGM

@zl03jsj zl03jsj merged commit f18dd11 into master Jul 8, 2022
@zl03jsj zl03jsj deleted the api/add-netdisconnect branch July 8, 2022 10:23
simlecode added a commit that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants