Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: venus-venus: change to build docker image from local repo #4912

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

LinZexiao
Copy link
Collaborator

Related Issues

Proposed Changes

change to build docker image from local repo rather than from git chech out
pass env var BUILD_DOCKER_PROXY to docker when make image
change golang version of buildenv to 1.17

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@codecov-commenter
Copy link

Codecov Report

Merging #4912 (18a4bb1) into master (6f6784f) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4912   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         576     576           
  Lines       62066   62066           
======================================
- Hits        15755   15753    -2     
- Misses      44158   44161    +3     
+ Partials     2153    2152    -1     

@simlecode simlecode merged commit b391a09 into master Jun 15, 2022
@simlecode simlecode deleted the fix/tanlang/docker_ch_buildbase branch June 15, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants