Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(venus-shared): more fields defined in market.GetDealSpec #4885

Merged
merged 2 commits into from
May 13, 2022

Conversation

dtynn
Copy link
Contributor

@dtynn dtynn commented May 13, 2022

Related Issues

n/a

Proposed Changes

type changes for adding more policy in AssignedUnPackedDeals

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • CI is green

@codecov-commenter
Copy link

Codecov Report

Merging #4885 (da04e9b) into master (eef27d3) will decrease coverage by 0%.
The diff coverage is n/a.

❗ Current head da04e9b differs from pull request most recent head 9fe5ba0. Consider uploading reports for the commit 9fe5ba0 to get more accurate results

@@          Coverage Diff           @@
##           master   #4885   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         576     576           
  Lines       62066   62066           
======================================
- Hits        15775   15772    -3     
- Misses      44141   44143    +2     
- Partials     2150    2151    +1     

Copy link
Contributor

@zl03jsj zl03jsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

igtm

@zl03jsj zl03jsj merged commit 19620ae into master May 13, 2022
@zl03jsj zl03jsj deleted the feat/dtynn/more_policy_in_assign_unpacked_deals branch May 13, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants