Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api: add StateGetNetworkParmas #4875

Merged
merged 2 commits into from
May 11, 2022

Conversation

simlecode
Copy link
Collaborator

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@simlecode simlecode force-pushed the feat/state_get_networt_params_api branch from d4f7727 to 1848225 Compare May 11, 2022 08:05
@simlecode simlecode requested review from hunjixin and zl03jsj May 11, 2022 08:40
Copy link
Contributor

@zl03jsj zl03jsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itgm

Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/submodule/chain/chaininfo_api.go Show resolved Hide resolved
@simlecode simlecode force-pushed the feat/state_get_networt_params_api branch from 7780f92 to ee4fdd8 Compare May 11, 2022 09:16
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #4875 (ee4fdd8) into master (1352328) will decrease coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #4875   +/-   ##
======================================
- Coverage      25%     25%   -1%     
======================================
  Files         576     576           
  Lines       62008   62066   +58     
======================================
+ Hits        15773   15775    +2     
- Misses      44085   44141   +56     
  Partials     2150    2150           

@simlecode simlecode merged commit eef27d3 into master May 11, 2022
@simlecode simlecode deleted the feat/state_get_networt_params_api branch May 11, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

venus增加网络参数接口,其他项目需要网络需要网络相关参数,需通过接口获取
4 participants