Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tanlang/add sign recorder #123

Merged
merged 12 commits into from
Feb 28, 2023
Merged

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Feb 23, 2023

关联的Issues (Related Issues)

close filecoin-project/venus#5725

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao requested a review from simlecode February 23, 2023 07:36
storage/sqlite/sign_record.go Show resolved Hide resolved
storage/sqlite/sign_record.go Show resolved Hide resolved
storage/wallet/wallet.go Outdated Show resolved Hide resolved
@LinZexiao LinZexiao requested a review from hunjixin February 24, 2023 03:44
.gitignore Outdated Show resolved Hide resolved
cli/record.go Outdated Show resolved Hide resolved
cli/record.go Outdated Show resolved Hide resolved
common/api_common.go Outdated Show resolved Hide resolved
@LinZexiao LinZexiao force-pushed the feat/tanlang/add-sign-recorder branch from 722fdca to cbf6b8a Compare February 24, 2023 07:45
change QueryRecord to ListRecord
record signed record with go runtime
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #123 (02b8d13) into master (2d97ede) will decrease coverage by 0.73%.
The diff coverage is 18.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   33.46%   32.74%   -0.73%     
==========================================
  Files          40       42       +2     
  Lines        2456     2669     +213     
==========================================
+ Hits          822      874      +52     
- Misses       1496     1642     +146     
- Partials      138      153      +15     
Flag Coverage Δ
unittests 32.74% <18.91%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/helper/helper.go 21.55% <0.00%> (-1.82%) ⬇️
cli/record.go 0.00% <0.00%> (ø)
common/api_common.go 50.00% <0.00%> (-5.00%) ⬇️
storage/wallet/sign_type.go 0.98% <1.23%> (+0.98%) ⬆️
storage/wallet/wallet.go 22.70% <6.06%> (+1.60%) ⬆️
storage/sqlite/sign_record.go 56.32% <56.32%> (ø)
build/builder.go 89.39% <100.00%> (+0.16%) ⬆️
filemgr/config_manager.go 69.30% <100.00%> (ø)
filemgr/fs.go 58.46% <100.00%> (ø)
storage/sqlite/conn.go 50.00% <100.00%> (ø)
... and 2 more

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit c591b11 into master Feb 28, 2023
@simlecode simlecode deleted the feat/tanlang/add-sign-recorder branch February 28, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-wallet] save sign record / 保存签名记录
4 participants