This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Fix: sector extension error #1309 #1310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al proof types may be extended
|
This behaviour is by design, which we can discuss that in #1309. I am going to close this PR because even if we decided to change it, the change would have to land with a new network version upgrade (v9 or greater) in order to preserve chain history compatibility. |
|
V1 proof do windowPOST have no security problem.I think V1 proof should be allowed extension to maxLifetime.Otherwise it is unfair to the miners of V1 proof sectors. |
|
I don't think it's unfair to V1 proof sectors as there are almost SP1 sectors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.