-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Non-interactive PoRep #98
Conversation
Can you rebase this on top of #97 instead of master, since that's pending the proofs release already? |
OK, I've rebased. @cryptonemo Please do not squash this PR and yours into a single commit. Either merge them separately or at least a proper merge commit. It's very valuable to have the changes for Ni-PoRep in a separate commit. It helps when someone does similar changes (just like I used the Synth-PoRep commit as a template for my change). |
You already know I don't agree here. Also, I plan to push some changes because there are things I'd like to clean-up. So would you prefer I open a new PR or can we work collaboratively on this one? |
Actually, here's a better way -- let's just merge the original PR, merge this one, then I'll build on master. You have your valuable history and things get done either way? 🤷♂️ |
I think just merging the PRs in order is certainly less work and I'd prefer that :) |
Ok, good to rebase now. For FFI, we'll have to cut the releases first and then merge in order as well |
It was automatically rebased. Feel free to merge. |
This commit introduces new registered proof types in order to support ni-porep. Also Rust >= 1.70 is needed due to the dependency on `home` v0.5.9.
This commit introduces new registered proof types in order to support ni-porep.
Also Rust >= 1.70 is needed due to the dependency on
home
v0.5.9.