Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Non-interactive PoRep #98

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Apr 23, 2024

This commit introduces new registered proof types in order to support ni-porep.

Also Rust >= 1.70 is needed due to the dependency on home v0.5.9.

@cryptonemo
Copy link
Collaborator

Can you rebase this on top of #97 instead of master, since that's pending the proofs release already?

@vmx vmx changed the base branch from master to improved-error-handling April 23, 2024 17:58
@vmx
Copy link
Contributor Author

vmx commented Apr 23, 2024

OK, I've rebased. @cryptonemo Please do not squash this PR and yours into a single commit. Either merge them separately or at least a proper merge commit. It's very valuable to have the changes for Ni-PoRep in a separate commit. It helps when someone does similar changes (just like I used the Synth-PoRep commit as a template for my change).

@cryptonemo
Copy link
Collaborator

It's very valuable to have the changes for Ni-PoRep in a separate commit.

You already know I don't agree here.

Also, I plan to push some changes because there are things I'd like to clean-up. So would you prefer I open a new PR or can we work collaboratively on this one?

@cryptonemo
Copy link
Collaborator

Actually, here's a better way -- let's just merge the original PR, merge this one, then I'll build on master. You have your valuable history and things get done either way? 🤷‍♂️

@vmx
Copy link
Contributor Author

vmx commented Apr 23, 2024

I think just merging the PRs in order is certainly less work and I'd prefer that :)

Base automatically changed from improved-error-handling to master April 23, 2024 19:11
@cryptonemo
Copy link
Collaborator

Ok, good to rebase now. For FFI, we'll have to cut the releases first and then merge in order as well

@vmx
Copy link
Contributor Author

vmx commented Apr 23, 2024

It was automatically rebased. Feel free to merge.

This commit introduces new registered proof types in order to support ni-porep.

Also Rust >= 1.70 is needed due to the dependency on `home` v0.5.9.
@cryptonemo cryptonemo merged commit 0fde8f9 into master May 6, 2024
3 checks passed
@cryptonemo cryptonemo deleted the ni-porep branch May 6, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants