feat: non-interactive PoRep #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
force-pushed
the
ni-porep
branch
2 times, most recently
from
3a330e1 to
ea715cf
Compare
vmx
force-pushed
the
ni-porep
branch
2 times, most recently
from
035a4d3 to
145d141
Compare
cryptonemo
reviewed
Dec 8, 2023
Adding non-interactive PoRep. It's similar to the interactive PoRep, but it performance 12.6x the amount of proofs. In order to not overwhelm the system with too many parallel proofs, they are split into batches of 10, which then leads to a similar resource consumption per batch as for a single interactive PoRep.
|
OK, I've rebased the commit and added a proper commit message, which I've also added to the description of this PR. |
cryptonemo
reviewed
Dec 19, 2023
| pub(crate) const fn get_porep_non_interactive_minimum_challenges(sector_size: u64) -> usize { | ||
| match sector_size { | ||
| SECTOR_SIZE_2_KIB | SECTOR_SIZE_4_KIB | SECTOR_SIZE_16_KIB | SECTOR_SIZE_32_KIB | ||
| | SECTOR_SIZE_8_MIB | SECTOR_SIZE_16_MIB | SECTOR_SIZE_512_MIB | SECTOR_SIZE_1_GIB => 4, |
There was a problem hiding this comment.
Was the test sector size challenge count specified in the spec? Can't recall
There was a problem hiding this comment.
No the test sector size is not specified in the spec, but I thought I pick one different from the interactive porep.
cryptonemo
reviewed
Dec 19, 2023
DrPeterVanNostrand
previously approved these changes
Dec 19, 2023
DrPeterVanNostrand
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding non-interactive PoRep. It's similar to the interactive PoRep, but
it performance 12.6x the amount of proofs. In order to not overwhelm the
system with too many parallel proofs, they are split into batches of 10,
which then leads to a similar resource consumption per batch as for a
single interactive PoRep.