Skip to content

Comments

fix(fvm): accept malleable secp256k1 signatures (per EVM, etc.)#2156

Merged
rvagg merged 1 commit intomasterfrom
steb/accept-malleable-secp256k1
Apr 15, 2025
Merged

fix(fvm): accept malleable secp256k1 signatures (per EVM, etc.)#2156
rvagg merged 1 commit intomasterfrom
steb/accept-malleable-secp256k1

Conversation

@Stebalien
Copy link
Member

And add a test case.

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Apr 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.49%. Comparing base (bef9854) to head (9fbd582).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
+ Coverage   77.45%   77.49%   +0.03%     
==========================================
  Files         147      147              
  Lines       15709    15736      +27     
==========================================
+ Hits        12167    12194      +27     
  Misses       3542     3542              
Files with missing lines Coverage Δ
shared/src/crypto/signature.rs 72.75% <100.00%> (+2.68%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stebalien Stebalien requested a review from rvagg April 15, 2025 03:28
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, ok, worth recording here that the context is mostly in RustCrypto/elliptic-curves#988, foundry-rs had a similar issue and it was resolved in revm which looks a lot like what we're implementing here: bluealloy/revm#870

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Apr 15, 2025
@rvagg rvagg merged commit 8b42938 into master Apr 15, 2025
15 checks passed
@rvagg rvagg deleted the steb/accept-malleable-secp256k1 branch April 15, 2025 05:46
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants