fix(fvm): accept malleable secp256k1 signatures (per EVM, etc.)#2156
Merged
fix(fvm): accept malleable secp256k1 signatures (per EVM, etc.)#2156
Conversation
And add a test case.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2156 +/- ##
==========================================
+ Coverage 77.45% 77.49% +0.03%
==========================================
Files 147 147
Lines 15709 15736 +27
==========================================
+ Hits 12167 12194 +27
Misses 3542 3542
🚀 New features to boost your workflow:
|
rvagg
approved these changes
Apr 15, 2025
Member
rvagg
left a comment
There was a problem hiding this comment.
yeah, ok, worth recording here that the context is mostly in RustCrypto/elliptic-curves#988, foundry-rs had a similar issue and it was resolved in revm which looks a lot like what we're implementing here: bluealloy/revm#870
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add a test case.