Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 4.3.2 #2030

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Aug 1, 2024

Closes #2028

Updated Cargo.toml for a new release.
Dates were wrong in the CHANGELOG.md files for 2024 releases (lmk if I am wrong).

If you guys want to merge more PRs before the release and make it a breaking change, happy to wait for it.

cc @rjan90

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.03%. Comparing base (490cd42) to head (09b8a73).

❗ There is a different number of reports uploaded between BASE (490cd42) and HEAD (09b8a73). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (490cd42) HEAD (09b8a73)
4 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2030       +/-   ##
===========================================
- Coverage   75.63%   22.03%   -53.61%     
===========================================
  Files         155      115       -40     
  Lines       15676    10680     -4996     
===========================================
- Hits        11857     2353     -9504     
- Misses       3819     8327     +4508     

see 129 files with indirect coverage changes

@rjan90
Copy link
Contributor

rjan90 commented Aug 2, 2024

Thanks for the PR, and also catching the wrong dates in the Changelog 🙏

If you guys want to merge more PRs before the release and make it a breaking change, happy to wait for it.

I think we want at least: #2027 to land. So that we can test out the automatic creation of GitHub releases and tags workflow. We are currently targeting to land this next week.

@kamuik16
Copy link
Contributor Author

Thanks for the PR, and also catching the wrong dates in the Changelog 🙏

If you guys want to merge more PRs before the release and make it a breaking change, happy to wait for it.

I think we want at least: #2027 to land. So that we can test out the automatic creation of GitHub releases and tags workflow. We are currently targeting to land this next week.

Hey! when do you think this would land?

@Stebalien Stebalien enabled auto-merge (squash) August 16, 2024 15:22
@Stebalien Stebalien merged commit 2f5340c into filecoin-project:master Aug 16, 2024
14 checks passed
@kamuik16 kamuik16 deleted the nv24-release branch August 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton for nv24 to support development and testing
4 participants