Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NI-PoRep support #2010

Merged
merged 8 commits into from
Jun 12, 2024
Merged

NI-PoRep support #2010

merged 8 commits into from
Jun 12, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 28, 2024

#1999 rebased on master with some minor changes and local Cargo.toml linking

@rvagg rvagg force-pushed the rvagg/nlucic/niporep branch from 0817253 to 6d9b723 Compare May 29, 2024 00:26
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.

Project coverage is 75.63%. Comparing base (206a772) to head (d778998).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
- Coverage   75.67%   75.63%   -0.04%     
==========================================
  Files         155      155              
  Lines       15669    15676       +7     
==========================================
  Hits        11857    11857              
- Misses       3812     3819       +7     
Files Coverage Δ
shared/src/sector/registered_proof.rs 6.41% <3.57%> (-0.20%) ⬇️

@rvagg rvagg changed the title ni-porep temp (DO NOT MERGE) NI-PoRep support Jun 6, 2024
@rvagg rvagg marked this pull request as ready for review June 6, 2024 02:39
@rvagg rvagg requested review from Stebalien and anorth June 6, 2024 02:42
@rvagg rvagg force-pushed the rvagg/nlucic/niporep branch from c74f065 to 9501007 Compare June 6, 2024 02:42
@rvagg
Copy link
Member Author

rvagg commented Jun 6, 2024

@anorth @Stebalien @NemanjaLu92 I'd like to propose this replace #1999 and be merged as it is. It's essentially the same as #1999 but rebased on master and with a correct proofs dependency version. I've been using this for local testing but I'm keen to move us closer to a tag because cargo linking to the git repo for ref-fvm in filecoin-ffi is a bit of a nightmare thanks to the multiple versions.

shared/src/sector/registered_proof.rs Outdated Show resolved Hide resolved
shared/src/sector/registered_proof.rs Outdated Show resolved Hide resolved
@rvagg rvagg requested review from anorth and cryptonemo June 11, 2024 10:20
@rvagg
Copy link
Member Author

rvagg commented Jun 11, 2024

feedback addressed

@rvagg
Copy link
Member Author

rvagg commented Jun 11, 2024

Also renamed all the NI-PoRep proofs types to be V1P2 rather than V1P1

Cargo.lock Outdated Show resolved Hide resolved
@Stebalien Stebalien merged commit 27e7838 into master Jun 12, 2024
15 of 16 checks passed
@Stebalien Stebalien deleted the rvagg/nlucic/niporep branch June 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

7 participants