fix: BufferedBlockstore#flush should not reset the write buffer. #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resetting the buffer was never advertised as a behaviour of this method. This makes it possible to call flush multiple times to selectively flush roots during its lifetime. Selective flushes are used to flush the event AMTs as they are being produced.
Stebalien
approved these changes
Nov 16, 2022
raulk
added a commit
that referenced
this pull request
Nov 16, 2022
Resetting the buffer was never advertised as a behaviour of this method. This makes it possible to call flush multiple times to selectively flush roots during its lifetime. Selective flushes are used to flush the event AMTs as they are being produced.
raulk
added a commit
that referenced
this pull request
Nov 16, 2022
Resetting the buffer was never advertised as a behaviour of this method. This makes it possible to call flush multiple times to selectively flush roots during its lifetime. Selective flushes are used to flush the event AMTs as they are being produced.
raulk
added a commit
that referenced
this pull request
Nov 16, 2022
Resetting the buffer was never advertised as a behaviour of this method. This makes it possible to call flush multiple times to selectively flush roots during its lifetime. Selective flushes are used to flush the event AMTs as they are being produced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting the buffer was never advertised as a behaviour of this method.
This makes it possible to call flush multiple times to selectively flush roots during its lifetime. Selective flushes are used to flush the event AMTs as they are being produced.