feat: state: add a second premigration for nv17 #9525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
Oct 20, 2022
cmd/lotus-shed/migrations.go
Outdated
| } | ||
|
|
||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| func checkStateInvariants(ctx context.Context, v8StateRoot cid.Cid, v9StateRoot cid.Cid, bs blockstore.Blockstore) error { | ||
| actorStore := store.ActorStore(ctx, blockstore.NewTieredBstore(bs, blockstore.NewMemorySync())) | ||
| func checkStateInvariants(ctx context.Context, v8StateRoot cid.Cid, v9StateRoot cid.Cid, bs blockstore.Blockstore, epoch abi.ChainEpoch) error { |
There was a problem hiding this comment.
For clarity all instances of checkStateInvariants should change to i.e. checkMigrationInvariants. This is the historical name for the pure state invariants check called as a subset of all migration checks in the commented out code below. Calls to check only the v9 pure state invariants should exist as a standalone command.
There was a problem hiding this comment.
Good feedback, thank you!
arajasek
force-pushed
the
asr/premigrations
branch
from
8a00c8c to
7609655
Compare
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
More work towards optimizing the migration
Proposed Changes
We move the first premigration back to be 2 hours before the upgrade.
We add a second premigration 7.5 minutes before the upgrade.
This PR also adds more functionality to the lotus-shed tools around migrations and state diffs.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps