-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deps: update go-libp2p to v0.21 #8970
chore: deps: update go-libp2p to v0.21 #8970
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8970 +/- ##
==========================================
+ Coverage 35.19% 40.65% +5.45%
==========================================
Files 703 707 +4
Lines 78466 78671 +205
==========================================
+ Hits 27620 31987 +4367
+ Misses 45851 41209 -4642
- Partials 4995 5475 +480
|
@MarcoPolo thank you for opening the draft PR! We noticed that https://github.com/libp2p/go-libp2p/releases/tag/v0.21.0 is now published, im wondering if you are planning to update this branch to the stable release and open PR for review? it'd be great if we can have rcmgr autoscale in lotus & and have lotus nodes exposes opencensus metrics as well |
Yup! planning on doing that today :) I'll probably split this into two PRs. One with just the dep updates and the other that enables the opencensus metrics. |
b5caf08
to
6ae75aa
Compare
We should merge filecoin-project/go-fil-markets#744 first and we can update the go-fil-markets dep here as well. |
thanks @MarcoPolo pinged market maintainer for t he review there, tho we probably should do separate PR for updating the market version! |
We need to update go-fil-markets before merging this PR since there was a breaking change in go-libp2p-core and the current go-fil-markets wouldn't work with this PR since it updates go-libp2p-core. You get this error if you try:
|
node/modules/lp2p/rcmgr.go
Outdated
if err != nil { | ||
return nil, fmt.Errorf("error creating resource manager stats reporter: %w", err) | ||
} | ||
view.Register(obs.DefaultViews...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This registers the resource managers opencensus metrics
ah- ack! |
It looks like go-fil-markets and dht had releases for this change, what else is needed here? We have some overlap with this changeset on Boost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Will merge with tagged markets
Related Issues
Proposed Changes
Draft PR to help update lotus to use the latest release of go-libp2p.
Also adds observability to the resource manager via prometheus so operators can debug blocked resources better. See https://ipfs.marcopolo.io/d/MgmGIjjnk/resource-manager?orgId=1 for a live example.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps