Fix temporal problems in bad block cache#535
Merged
Conversation
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
| for _, b := range fts.Blocks { | ||
| if err := syncer.ValidateBlock(ctx, b); err != nil { | ||
| syncer.bad.Add(b.Cid()) | ||
| if !errors.Is(err, ErrTemporal) { |
Member
There was a problem hiding this comment.
One nitpick would be to have an IsPermanent function that calls this internally. Just to make the logic a little more readable
whyrusleeping
approved these changes
Nov 6, 2019
Member
whyrusleeping
left a comment
whyrusleeping
left a comment
There was a problem hiding this comment.
One small nitpick, but otherwise +1
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
approved these changes
Nov 8, 2019
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License: MIT