chore: backport #13535 and #13565 to the release/v1.35.1 branch#13566
Merged
rjan90 merged 2 commits intorelease/v1.35.1from Mar 31, 2026
Merged
chore: backport #13535 and #13565 to the release/v1.35.1 branch#13566rjan90 merged 2 commits intorelease/v1.35.1from
rjan90 merged 2 commits intorelease/v1.35.1from
Conversation
- Adds ErrBlockRangeExceeded with -32005 "limit exceeded" error code matching standard Ethereum JSON-RPC error code and message - Enforces MaxFilterHeightRange on EthTraceFilter (node-level) - Adds configurable EthTraceFilterMaxBlockRange (default 100) to the gateway, enforced via checkEthTraceFilterBlockRange - Converts EthGetLogs parseBlockRange errors to ErrBlockRangeExceeded for consistency with Ethereum ecosystem error conventions - Adds --eth-trace-filter-max-block-range CLI flag to lotus-gateway - Integration tests covering node and gateway limits for both v1 and v2
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
rvagg
approved these changes
Mar 31, 2026
Include null round epochs as 0-block entries in the chain data fed to the FRC-0089 calculator, rather than silently skipping them. This aligns the implementation with the theoretical model where null rounds are epochs where the adversary gains ground while the honest chain doesn't grow. Also fixes a depth-to-height conversion problem which previously could return a shallower tipset than intended when null rounds were present between head and the finalized epoch. Increase BisectHigh from 200 to 450 to accommodate degraded chains where null round inclusion pushes the threshold deeper (notably current calibnet which is near 200).
rjan90
changed the title
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
rjan90
changed the title
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
github-actions
Bot
dismissed
their stale review
PR title now matches the required format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#13535
Proposed Changes
Cherry-pick #13561 and #13565 to the v1.35.1 release branch
Checklist
Before you mark the PR ready for review, please make sure that: