Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes and hardens the ethtypes RLP codec used by Ethereum transaction parsing/encoding by adding stricter input validation (size/depth/canonical encoding) and improving some internal implementations.
Changes:
- Added decoder safety limits (max input length, max list depth) and canonical RLP encoding checks.
- Refactored length encoding/decoding and introduced clearer sentinel errors for common invalid cases.
- Expanded RLP test coverage with canonical/non-canonical, truncation/trailing-bytes, and roundtrip vectors (including go-ethereum-derived cases).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
chain/types/ethtypes/rlp.go |
Adds decoding limits and canonical checks; refactors length handling and error plumbing. |
chain/types/ethtypes/rlp_test.go |
Adds/updates tests for the new validation and canonicalization behavior, plus roundtrip vectors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wjmelements
reviewed
Mar 26, 2026
wjmelements
reviewed
Mar 27, 2026
wjmelements
approved these changes
Mar 27, 2026
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
rjan90
pushed a commit
that referenced
this pull request
Mar 30, 2026
8 tasks
rjan90
added a commit
that referenced
this pull request
Mar 30, 2026
* fix(rlp): modernisation, hardening, and perforance improvements (#13555) * chore: bump go-paramfetch to latest version (#13559) chore: bump go-paramfetch to latest version * fix(api): `StateSearchMsg` should respect `lookbackLimit` when using index (#13562) --------- Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: hanabi1224 <harlowmoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With input validation & canonical encoding checks, pulling in some learnings and test vectors from go-ethereum: https://github.com/ethereum/go-ethereum/tree/master/rlp