fix(basefee)!: add fip-0115 feature flag (LOTUS_FEES_FIP0115HEIGHT)#13550
Merged
wjmelements merged 3 commits intomasterfrom Mar 20, 2026
Merged
fix(basefee)!: add fip-0115 feature flag (LOTUS_FEES_FIP0115HEIGHT)#13550wjmelements merged 3 commits intomasterfrom
LOTUS_FEES_FIP0115HEIGHT)#13550wjmelements merged 3 commits intomasterfrom
Conversation
Replaces the hard-coded UpgradeXxHeight check in ComputeBaseFee with a configurable Fees.FIP0115Height (env: LOTUS_FEES_FIP0115HEIGHT). Defaults to -1 (disabled). Testers can set the epoch to activate the premium-based base fee algorithm independently of any network upgrade. WARNING: this is a consensus-breaking change and should only be used for testing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Test failure (itest-daily_fees) is unrelated, and might be fixed by #13551 |
70 tasks
ZenGround0
approved these changes
Mar 19, 2026
Contributor
ZenGround0
left a comment
ZenGround0
left a comment
There was a problem hiding this comment.
Looks good. Only thing I would add is a follow on issue for reverting this PR once the FIP is accepted. But you probably won't forget anyway.
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
Kubuxu
approved these changes
Mar 19, 2026
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers @rvagg @jennijuju
#13531 mistakenly scheduled FIP-0115 for inclusion in the next network version.
That change also causes the localnet to activate the feature at block 20.
This fix creates a flag that can be used to configure activation, allowing localnets to test activation.
It defaults to never activating (
-1), an improvement over the previous999999999999999activation.There is also a stern warning against activation.
Changes