Skip to content

fix(grammar): fix article mistakes in comments and error messages#13435

Merged
rjan90 merged 2 commits intofilecoin-project:masterfrom
lmorett1:typos9
Nov 27, 2025
Merged

fix(grammar): fix article mistakes in comments and error messages#13435
rjan90 merged 2 commits intofilecoin-project:masterfrom
lmorett1:typos9

Conversation

@lmorett1
Copy link
Copy Markdown
Contributor

Fix article mistakes in comments and error messages:

  • "a unsigned" → "an unsigned"
  • "a owner address" → "an owner address"
  • "ustom" → "custom"

[skip changelog]

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Nov 25, 2025
@rjan90
Copy link
Copy Markdown
Contributor

rjan90 commented Nov 25, 2025

As mentioned here: #13429 (comment). You need to run make gen to fix the CI issues here

@rjan90 rjan90 added the need/author-input Hint: Needs Author Input label Nov 25, 2025
@lmorett1
Copy link
Copy Markdown
Contributor Author

As mentioned here: #13429 (comment). You need to run make gen to fix the CI issues here

Hi @rjan90
I tried running make gen like you asked, but hit some build problems on my Windows machine—turns out I’m missing the native build dependencies for the filecoin-ffi submodule (stuff like the Rust toolchain and C compiler).
This PR only has simple fixes for typos and grammar in comments and error messages, though, so it shouldn’t impact any generated code at all.

@rjan90
Copy link
Copy Markdown
Contributor

rjan90 commented Nov 26, 2025

Ah, that is unfortunate. The openrpc/full.json files are autogenerated from these though, which is why it is failing. Example:

--- a/build/openrpc/full.json
+++ b/build/openrpc/full.json
@@ -10779,7 +10779,7 @@
{
"name": "Filecoin.MpoolBatchPushMessage",
"description": "go\nfunc (s *FullNodeStruct) MpoolBatchPushMessage(p0 context.Context, p1 []*types.Message, p2 *MessageSendSpec) ([]*types.SignedMessage, error) {\n\tif s.Internal.MpoolBatchPushMessage == nil {\n\t\treturn *new([]*types.SignedMessage), ErrNotSupported\n\t}\n\treturn s.Internal.MpoolBatchPushMessage(p0, p1, p2)\n}\n",

  •        "summary": "MpoolBatchPushMessage batch pushes a unsigned message to mempool.\n",
    
  •        "summary": "MpoolBatchPushMessage batch pushes an unsigned message to mempool.\n",
           "paramStructure": "by-position",
           "params": [
               {
    

@lmorett1
Copy link
Copy Markdown
Contributor Author

Ah, that is unfortunate. The openrpc/full.json files are autogenerated from these though, which is why it is failing. Example:

--- a/build/openrpc/full.json
+++ b/build/openrpc/full.json
@@ -10779,7 +10779,7 @@
{
"name": "Filecoin.MpoolBatchPushMessage",
"description": "go\nfunc (s *FullNodeStruct) MpoolBatchPushMessage(p0 context.Context, p1 []*types.Message, p2 *MessageSendSpec) ([]*types.SignedMessage, error) {\n\tif s.Internal.MpoolBatchPushMessage == nil {\n\t\treturn *new([]*types.SignedMessage), ErrNotSupported\n\t}\n\treturn s.Internal.MpoolBatchPushMessage(p0, p1, p2)\n}\n",

  •        "summary": "MpoolBatchPushMessage batch pushes a unsigned message to mempool.\n",
    
  •        "summary": "MpoolBatchPushMessage batch pushes an unsigned message to mempool.\n",
           "paramStructure": "by-position",
           "params": [
               {
    

Thanks for pointing this out! I've updated build/openrpc/full.json to match the source code changes.

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Nov 27, 2025
@rjan90 rjan90 merged commit 972f21c into filecoin-project:master Nov 27, 2025
95 checks passed
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Nov 27, 2025
aceppaluni pushed a commit to aceppaluni/lotus that referenced this pull request Dec 2, 2025
…lecoin-project#13435)

* fix(grammar): fix article mistakes in comments and error messages

* fix(grammar): fix article mistakes in comments and error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need/author-input Hint: Needs Author Input

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants