fix(err): don't present non-ethereum error as an ethereum-style#13406
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error message formatting to avoid presenting non-Ethereum errors in an Ethereum-style format. Previously, all execution errors were displayed with a revert reason field, even when the error wasn't Ethereum-related, leading to misleading error messages that showed "ERROR: revert reason is not cbor encoded bytes" for non-Ethereum failures.
Key Changes:
- Modified error message formatting to conditionally include revert reason only when present
- Changed CBOR decoding error handling to silently skip non-Ethereum errors instead of displaying an error message
- Refactored the reason string initialization from "none" to empty string with conditional assignment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjan90
approved these changes
Oct 27, 2025
github-project-automation
Bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
github-project-automation
Bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
1 task
8 tasks
aceppaluni
pushed a commit
to aceppaluni/lotus
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight mistake #13389, all errors get wrapped up in this style, which isn't appropriate and we see things like this:
CBOR decode errors would get hidden with this change, but it's not something we expect to be seeing, and in the case of an expected reason where none appears that would be worth chasing up as an isolated case.