Skip to content

feat(cli): lotus evm deploy prints message CID (#13241)#13378

Merged
wjmelements merged 6 commits intofilecoin-project:masterfrom
aceppaluni:feat/evm-deploy-msgcid
Oct 10, 2025
Merged

feat(cli): lotus evm deploy prints message CID (#13241)#13378
wjmelements merged 6 commits intofilecoin-project:masterfrom
aceppaluni:feat/evm-deploy-msgcid

Conversation

@aceppaluni
Copy link
Copy Markdown
Contributor

Related Issues

This PR aims to fix issue #7489

Proposed Changes

CLI prints message CID

Additional Info

N/A

Checklist

Before you mark the PR ready for review, please make sure that:

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Oct 7, 2025
@rjan90
Copy link
Copy Markdown
Contributor

rjan90 commented Oct 7, 2025

I think it is this issue ticket: #13241 that this PR is aiming to solve? Looks like it is wrong in the title/commit

@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Oct 7, 2025
@aceppaluni aceppaluni changed the title feat(cli): lotus evm deploy prints message CID (#7489) feat(cli): lotus evm deploy prints message CID (#13241) Oct 7, 2025
@aceppaluni
Copy link
Copy Markdown
Contributor Author

@rjan90 Thank you, I went ahead and fixed this. My apologies for the error.

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Oct 8, 2025

@wjmelements would you mind quickly looking at this? GasUsed (and the other items you mentioned in your "alternatives" section) could be printed here pretty easily since we have the receipt. Is message CID enough?

@wjmelements
Copy link
Copy Markdown
Contributor

since we have the receipt

Ah I didn't realize that but I do see that in the code now.

I'd like

  1. the CID to be printed before StateWaitMsg
  2. a flag to make StateWaitMsg optional (though still the default)
  3. if we StateWaitMsg, to print all of the same information as wait-msg in the same order.

This PR aims to fix issue #7489

This is the wrong issue. Actual issue is #13241

Comment thread cli/evm.go Outdated
@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Oct 8, 2025
@wjmelements wjmelements linked an issue Oct 8, 2025 that may be closed by this pull request
9 tasks
Comment thread cli/evm.go Outdated
Comment thread CHANGELOG.md Outdated
Comment thread cli/evm.go
Comment thread cli/evm.go Outdated
@wjmelements
Copy link
Copy Markdown
Contributor

Consult the test failures:

  • Run make docsgen-cli

@wjmelements wjmelements merged commit 1ec20f0 into filecoin-project:master Oct 10, 2025
95 checks passed
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

lotus evm deploy: output the messageCid

4 participants