fix(api): use params tipset-key to load the tipset for gas premium calculation#13357
Merged
rjan90 merged 2 commits intoSep 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the gas premium calculation in the Filecoin API by using the provided tipset-key parameter instead of always defaulting to the heaviest tipset.
- Updated
GasEstimateFeeCapandGasEstimateGasPremiumfunctions to accept and use theTipSetKeyparameter - Modified API layer to pass the
tskparameter through to the underlying utility functions - Changed parameter names from ignored (
_) to used (tsk/ts) to reflect actual usage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| node/impl/gasutils/gasutils.go | Updated core gas estimation functions to accept and use TipSetKey parameter instead of hardcoded heaviest tipset |
| node/impl/full/gas.go | Modified API layer functions to pass through the tipset key parameter and use it in gas estimation calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rvagg
approved these changes
Sep 24, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
TipSetKeyif it is provided in the API params instead of getting heaviest tipset (only use heaviest if API params doesn't have a TipSetKey)Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: