Skip to content

fix(miner): ensure sender account exists#13348

Merged
tediou5 merged 1 commit into
filecoin-project:masterfrom
asamuj:master
Sep 19, 2025
Merged

fix(miner): ensure sender account exists#13348
tediou5 merged 1 commit into
filecoin-project:masterfrom
asamuj:master

Conversation

@asamuj
Copy link
Copy Markdown
Contributor

@asamuj asamuj commented Sep 18, 2025

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

Copilot AI review requested due to automatic review settings September 18, 2025 08:24
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Sep 18, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the miner creation command where the code was incorrectly validating the owner account instead of the sender account before creating a miner.

  • Fixed account validation to check the sender account rather than the owner account

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cmd/lotus-shed/miner.go
@tediou5 tediou5 added the skip/changelog This change does not require CHANGELOG.md update label Sep 19, 2025
Copy link
Copy Markdown
Contributor

@tediou5 tediou5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for your pr.

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Sep 19, 2025
@tediou5 tediou5 merged commit ab2a301 into filecoin-project:master Sep 19, 2025
99 of 100 checks passed
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants