Skip to content

build: release Lotus Node and Miner v1.34.1#13342

Closed
TippyFlitsUK wants to merge 4 commits intorelease/v1.34.0from
release/v1.34.1
Closed

build: release Lotus Node and Miner v1.34.1#13342
TippyFlitsUK wants to merge 4 commits intorelease/v1.34.0from
release/v1.34.1

Conversation

@TippyFlitsUK
Copy link
Copy Markdown
Contributor

@TippyFlitsUK TippyFlitsUK commented Sep 15, 2025

Related Issues

The v1.34.0 release incorrectly shipped with filecoin-ffi v1.34.0-dev instead of the stable filecoin-ffi v1.34.0 release. This patch release corrects this packaging error to include the proper stable version with ref-fvm v4.7.3.

#13340

Proposed Changes

  • Update filecoin-ffi submodule from v1.34.0-dev to stable v1.34.0
  • Bump version to v1.34.1 in build/version.go
  • Update CHANGELOG.md with v1.34.1 patch release notes
  • Regenerate documentation via make gen and make docsgen-cli

Additional Info

All users running v1.34.0 should upgrade to v1.34.1 to ensure they have the correct stable version of filecoin-ffi.

Checklist

Before you mark the PR ready for review, please make sure that:

TippyFlits added 3 commits September 15, 2025 16:56
The v1.34.0 release incorrectly shipped with filecoin-ffi v1.34.0-dev
instead of the stable v1.34.0. This updates to the correct stable version
which includes the critical ref-fvm v4.7.3 update.
Patch release fixing filecoin-ffi version to use stable v1.34.0
Copy link
Copy Markdown
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the messaging in the changelog needs to adjust. Suggestion provided. Good to have @rjan90's clarification.

I'm basing this on https://filecoinproject.slack.com/archives/CP50PPW2X/p1757918270135649

Comment thread CHANGELOG.md Outdated
@github-project-automation github-project-automation Bot moved this from 📌 Triage to ⌨️ In Progress in FilOz Sep 15, 2025
@BigLep
Copy link
Copy Markdown
Member

BigLep commented Sep 15, 2025

For visibility, this is being done because of my incomplete backport in #13337

Co-authored-by: Steve Loeppky <biglep@filoz.org>
@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz Sep 15, 2025
@TippyFlitsUK TippyFlitsUK marked this pull request as ready for review September 16, 2025 15:37
Copy link
Copy Markdown
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target branch should be release/v1.34.1 and not release/v1.34.0. You might need to change the name of your own branch first.

@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to ⌨️ In Progress in FilOz Sep 16, 2025
@TippyFlitsUK
Copy link
Copy Markdown
Contributor Author

Closing due to branch conflict. Duplicate PR will be created with no changes.

@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to 🎉 Done in FilOz Sep 16, 2025
@TippyFlitsUK TippyFlitsUK deleted the release/v1.34.1 branch September 16, 2025 15:55
@BigLep
Copy link
Copy Markdown
Member

BigLep commented Sep 16, 2025

Replaced by #13345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants