chore: update nv27 codename#13334
Merged
Merged
Conversation
chore: update nv27 codename
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the Filecoin network version 27 (nv27) codename from "Xx" to "Goldenweek" to align with community discussions and official naming conventions.
- Renames all references to
UpgradeXxHeighttoUpgradeGoldenweekHeightacross configuration files - Updates corresponding environment variable names and documentation
- Modifies API response structures to reflect the new upgrade name
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| node/impl/full/state.go | Updates API response to use new upgrade field name |
| documentation/en/api-methods-v1-stable.md | Updates API documentation example response |
| documentation/en/api-methods-v0-deprecated.md | Updates deprecated API documentation example response |
| chain/consensus/filcns/upgrades.go | Updates upgrade configuration to reference new height constant |
| build/openrpc/gateway.json | Updates OpenRPC schema with new upgrade field name |
| build/buildconstants/params_*.go | Renames upgrade height constants and environment variables across all network configurations |
| api/types.go | Updates ForkUpgradeParams struct field name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
BigLep
approved these changes
Sep 11, 2025
Member
BigLep
left a comment
There was a problem hiding this comment.
Looks good. Just need to change to UpgradeGoldenWeekHeight per verbal to be consistent.
chore: update nv27 codename
BigLep
approved these changes
Sep 11, 2025
BigLep
pushed a commit
that referenced
this pull request
Sep 11, 2025
* chore: update nv27 codename chore: update nv27 codename * chore: update nv27 codename chore: update nv27 codename
3 tasks
BigLep
added a commit
that referenced
this pull request
Sep 11, 2025
* chore: update nv27 codename (#13334) * chore: update nv27 codename chore: update nv27 codename * chore: update nv27 codename chore: update nv27 codename * chore: update Mainnet Golden Week height (#13335) ``` 2025-09-24T23:00:00Z 5348280 ``` * chore: update deps for NV27 final release (#13336) * chore: update FFI * Add go-state-types and builtin-actors deps * Update actor bundles --------- Co-authored-by: TippyFlits <james@filoz.org> * chore: update filecoin-ffi submodule to match v1.34.0 dependency --------- Co-authored-by: Phi-rjan <orjan.roren@gmail.com> Co-authored-by: TippyFlits <james@filoz.org>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Updates the nv27 codename to Goldenweek, to be in line with filecoin-project/community#74 (comment)
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: