feat(shed): lotus-shed miner fees-inspect improvements#13212
Merged
Conversation
- Proper CSV output - Add --output to write to a file - Add resume capability from last processed epoch when using --output - --tipset only required if not resuming, now means "start" - --count is optional, will default to chain head - Always walk from oldest to newest so keeping a file updated is easier - Nice progress indicator when writing to a file - Improve efficiency comment for inspectMiner function
rvagg
force-pushed
the
rvagg/fees-inspect-improve
branch
from
65c282f to
67f19b1
Compare
rjan90
approved these changes
Jul 15, 2025
Contributor
rjan90
left a comment
rjan90
left a comment
There was a problem hiding this comment.
This does break the command for existing users, but since that's probably just me I think that's OK.
That is probably fine. Looks good to me as long as tests pass
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
Member
Author
|
This is so much better than my previous workflow .. catch up in progress using an existing data file (which I've had to reformat a bit to make compatible): |
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does break the command for existing users, but since that's probably just me I think that's OK. The main breakage is in the ordering of the output and the fact that
--tipsetis that start and we go forward for--countor until head.