fix(cli): correctly construct the TerminateSectors params#13207
Merged
rjan90 merged 1 commit intofilecoin-project:masterfrom Jul 15, 2025
Merged
fix(cli): correctly construct the TerminateSectors params#13207rjan90 merged 1 commit intofilecoin-project:masterfrom
rjan90 merged 1 commit intofilecoin-project:masterfrom
Conversation
14fc540 to
cc08621
Compare
tediou5
approved these changes
Jul 10, 2025
Contributor
tediou5
left a comment
There was a problem hiding this comment.
Look good to me, thank you very much.
Contributor
|
I'll run some tests to see if this approach actually saves on gas. |
|
Nice |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this will actually save gasused, but I think the theory will. If I'm wrong, please don't hesitate to close this PR.
before
after