Skip to content

fix(cli): correctly construct the TerminateSectors params#13207

Merged
rjan90 merged 1 commit intofilecoin-project:masterfrom
beck-8:fix/terminateSectors
Jul 15, 2025
Merged

fix(cli): correctly construct the TerminateSectors params#13207
rjan90 merged 1 commit intofilecoin-project:masterfrom
beck-8:fix/terminateSectors

Conversation

@beck-8
Copy link
Contributor

@beck-8 beck-8 commented Jul 10, 2025

I'm not sure if this will actually save gasused, but I think the theory will. If I'm wrong, please don't hesitate to close this PR.

before

{
  "Terminations": [
    {
      "Deadline": 2,
      "Partition": 0,
      "Sectors": "2500"
    },
    {
      "Deadline": 2,
      "Partition": 0,
      "Sectors": "2501"
    },]}

after

{
 "Terminations": [
   {
     "Deadline": 2,
     "Partition": 0,
     "Sectors": "2500-2501"
   },]}

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Jul 10, 2025
@beck-8 beck-8 force-pushed the fix/terminateSectors branch from 14fc540 to cc08621 Compare July 10, 2025 07:14
@rjan90 rjan90 requested a review from tediou5 July 10, 2025 07:17
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Jul 10, 2025
Copy link
Contributor

@tediou5 tediou5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, thank you very much.

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Jul 10, 2025
@tediou5
Copy link
Contributor

tediou5 commented Jul 10, 2025

I'll run some tests to see if this approach actually saves on gas.

@eddieperez88
Copy link

Nice

@rjan90 rjan90 merged commit 4e247d1 into filecoin-project:master Jul 15, 2025
95 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jul 15, 2025
@beck-8 beck-8 deleted the fix/terminateSectors branch July 15, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants