ci: mark api v2 and eth api f3 tests as needing params#13162
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration to mark API v2 and ETH API f3 tests as requiring additional parameters.
- Adds "itest-api_v2" and "itest-eth_api_f3" to the parameters-needed test group.
- Reorders "itest-niporep_manual" in the test group list to align with the new configuration.
Comments suppressed due to low confidence (2)
cmd/ci/main.go:311
- [nitpick] Consider adding an inline comment to clarify why 'itest-api_v2' is marked as needing parameters.
"itest-api_v2",
cmd/ci/main.go:315
- [nitpick] Consider adding an inline comment to explain the requirement for extra parameters for ETH API f3 tests.
"itest-eth_api_f3",
rjan90
approved these changes
Jun 9, 2025
rvagg
approved these changes
Jun 9, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Mark API v2 and eth API f3 tests as one needing params.
Additional Info
This is a follow-up to a discussion we had in Slack.
Checklist
Before you mark the PR ready for review, please make sure that: