Skip to content

ci: mark api v2 and eth api f3 tests as needing params#13162

Merged
galargh merged 1 commit intomasterfrom
needs-params
Jun 9, 2025
Merged

ci: mark api v2 and eth api f3 tests as needing params#13162
galargh merged 1 commit intomasterfrom
needs-params

Conversation

@galargh
Copy link
Contributor

@galargh galargh commented Jun 9, 2025

Related Issues

Proposed Changes

Mark API v2 and eth API f3 tests as one needing params.

Additional Info

This is a follow-up to a discussion we had in Slack.

Checklist

Before you mark the PR ready for review, please make sure that:

@galargh galargh requested review from Copilot, rjan90 and rvagg June 9, 2025 08:10
@galargh galargh added the skip/changelog This change does not require CHANGELOG.md update label Jun 9, 2025
@github-project-automation github-project-automation bot moved this to Todo in F3 Jun 9, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Jun 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI configuration to mark API v2 and ETH API f3 tests as requiring additional parameters.

  • Adds "itest-api_v2" and "itest-eth_api_f3" to the parameters-needed test group.
  • Reorders "itest-niporep_manual" in the test group list to align with the new configuration.
Comments suppressed due to low confidence (2)

cmd/ci/main.go:311

  • [nitpick] Consider adding an inline comment to clarify why 'itest-api_v2' is marked as needing parameters.
        "itest-api_v2",

cmd/ci/main.go:315

  • [nitpick] Consider adding an inline comment to explain the requirement for extra parameters for ETH API f3 tests.
        "itest-eth_api_f3",

@github-project-automation github-project-automation bot moved this from Todo to In review in F3 Jun 9, 2025
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Jun 9, 2025
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @galargh !

@galargh galargh merged commit c71103f into master Jun 9, 2025
103 checks passed
@galargh galargh deleted the needs-params branch June 9, 2025 09:38
@github-project-automation github-project-automation bot moved this from In review to Done in F3 Jun 9, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants