Conversation
…izing or is stalled. This lack of clarification in the documentation was identified when creating docs for RPC providers and exchanges.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR clarifies how the /v2 APIs behave when Filecoin Fast Finality (F3) is not finalizing or falls behind EC finality, updating documentation and table of contents accordingly.
- Adds new FAQ sections and ToC entries about F3 non-finalization and EC fallback
- Expands the
finalizedtag description and flowchart to illustrate fallback logic - Fixes minor markdown and punctuation inconsistencies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| documentation/en/api-experimental-user-facing-v2-docs/api-v2-experimental.md | Clarified F3 fallback behavior, updated ToC and flowchart, tweaked copy |
| documentation/en/api-experimental-user-facing-v2-docs/CLAUDE.md | Updated related-code file descriptions |
Comments suppressed due to low confidence (1)
documentation/en/api-experimental-user-facing-v2-docs/api-v2-experimental.md:10
- [nitpick] The phrase 'if last finalized tipset is more than EC-finalized tipsets in the past' is ambiguous; consider rephrasing to clearly state the condition, for example: 'if the F3-finalized tipset is older than the EC-finalized tipset by more than the EC finality threshold.'
2025-06-06: Updated to make clear the impact on the APIs if F3 isn't finalizing or if last finalized tipset is more than EC-finalized tipsets in the past. This was reviewed in [PR #13161](https://github.com/filecoin-project/lotus/pull/13161).
documentation/en/api-experimental-user-facing-v2-docs/api-v2-experimental.md
Outdated
Show resolved
Hide resolved
documentation/en/api-experimental-user-facing-v2-docs/api-v2-experimental.md
Outdated
Show resolved
Hide resolved
documentation/en/api-experimental-user-facing-v2-docs/api-v2-experimental.md
Show resolved
Hide resolved
rjan90
approved these changes
Jun 6, 2025
Contributor
rjan90
left a comment
rjan90
left a comment
There was a problem hiding this comment.
Some typos caught by the copilot review that would be nice to commit, but else it looks good to me!
BigLep
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
…xperimental.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…xperimental.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
masih
approved these changes
Jun 9, 2025
github-project-automation
bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FilOz
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lack of clarification in the documentation was identified when creating docs for RPC providers and exchanges.