feat(spcli): make settle-deal optionally take deal id ranges#13146
Merged
feat(spcli): make settle-deal optionally take deal id ranges#13146
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds optional range support to the settle-deal command so users can specify deal IDs as individual numbers or ranges.
- Updates documentation to mention range syntax in both general CLI docs and the
lotus-minerhelp output - Extends the
settle-dealhandler to parse hyphenated ranges and expand them into individual deal IDs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| documentation/en/cli-lotus-miner.md | Updated usage examples to show how to pass individual IDs or ranges |
| cli/spcli/actor.go | Added strings import, enhanced Usage text, and implemented range parsing in settle-deal |
Comments suppressed due to low confidence (3)
cli/spcli/actor.go:44
- [nitpick] Update the ArgsUsage string to indicate that ranges are supported (e.g.,
"[...dealIds|ranges]") so users know how to pass hyphenated ranges.
ArgsUsage: "[...dealIds]",
cli/spcli/actor.go:75
- Add unit tests for the range parsing logic, covering valid ranges, invalid formats, and reversed ranges to ensure the new behavior is fully tested.
if strings.Contains(d, "-") {
cli/spcli/actor.go:101
- Rename the variable
dealIdtodealIDto follow Go conventions for acronyms and improve consistency withdealIDs.
dealId, err = strconv.ParseUint(d, 10, 64)
03f6b5f to
8130066
Compare
rjan90
approved these changes
May 29, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @simlecode