feat(f3): update go-f3, move EC cache to go-f3#13144
Merged
Conversation
e33707f to
ad5d48f
Compare
df7da32 to
ed2c190
Compare
5 tasks
14ffdb6 to
87cc522
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the integration with go-f3 by introducing a dedicated F3 datastore (with migration), adjusting DI overrides, cleaning up legacy manifest provider code, and bumping related dependencies.
- Introduce
F3Datastoreprovider anddtypes.F3DSalias - Add migration logic to move data from the metadata store into the new F3 store
- Remove legacy manifest provider override and related helper code/tests; bump
go-f3and other dependencies
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| node/repo/fsrepo_ds.go | Added "f3" to fsDatastores; flagged unused badgerDs helper |
| node/modules/storage.go | New F3Datastore DI provider that returns a separate datastore |
| node/modules/dtypes/storage.go | Defined type F3DS datastore.Batching for F3 data |
| node/builder_chain.go | Override dtypes.F3DS in Fx options; removed manifest override |
| itests/kit/node_opts.go | Removed legacy manifest imports and unsets |
| itests/f3_test.go, eth_api_f3_test.go | Updated test flows to use new config and mock proofs |
| go.mod | Bumped go-f3, x/sync, and pion dependencies |
| documentation/en/api-v1-unstable-methods.md | Removed deprecated response fields (Pause, ExplicitPower, IgnoreECPower) |
| build/openrpc/full.json | Synced OpenRPC spec with removed fields |
| chain/store/store.go | Enhanced error message with contextual values |
| chain/lf3/f3.go | Added migration functions and updated constructor |
| chain/lf3/participation_lease.go, participation_lease_test.go | Changed manifest/Progress signatures; removed nil checks |
| build/params_shared_funcs.go | Removed obsolete passive-testing env var helpers |
Comments suppressed due to low confidence (4)
node/modules/storage.go:63
- [nitpick] The variable
mdssuggests metadata datastore; consider renaming it tof3dsordsto reflect its role for F3 data.
mds, err := r.Datastore(ctx, "/f3")
node/modules/dtypes/storage.go:15
- The comment implies F3DS is namespaced under
/f3in the main repo datastore, but it now uses a separate datastore; please update the comment to reflect the new behavior.
// F3DS stores F3 data. By default it's namespaced under /f3 in main repo datastore.
node/repo/fsrepo_ds.go:22
- The
badgerDshelper and its imports are reported unused; consider removing the unused code and cleaning up imports.
// Helper badgerDs() and its imports are unused
chain/lf3/f3.go:105
- The code uses
xerrors.Errorfbutgolang.org/x/xerrorsis not imported; either add the import or switch tofmt.Errorf.
return xerrors.Errorf("checking if migration complete: %w", err)
db25056 to
6fbd5dc
Compare
masih
approved these changes
Jun 12, 2025
5 tasks
6f4b4dc to
53fd1a6
Compare
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
53fd1a6 to
7652884
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: