Skip to content

feat(f3): update go-f3, move EC cache to go-f3#13144

Merged
Kubuxu merged 2 commits intomasterfrom
feat/f3-cache-changes
Jun 16, 2025
Merged

feat(f3): update go-f3, move EC cache to go-f3#13144
Kubuxu merged 2 commits intomasterfrom
feat/f3-cache-changes

Conversation

@Kubuxu
Copy link
Copy Markdown
Contributor

@Kubuxu Kubuxu commented May 26, 2025

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz May 26, 2025
@github-project-automation github-project-automation bot moved this to Todo in F3 May 26, 2025
@BigLep BigLep moved this from Todo to In progress in F3 May 26, 2025
@Kubuxu Kubuxu force-pushed the feat/f3-cache-changes branch from e33707f to ad5d48f Compare June 6, 2025 15:06
@BigLep BigLep mentioned this pull request May 26, 2025
43 tasks
@Kubuxu Kubuxu force-pushed the feat/f3-cache-changes branch from df7da32 to ed2c190 Compare June 9, 2025 14:27
@Kubuxu Kubuxu requested a review from masih June 9, 2025 15:10
@BigLep BigLep moved this from In progress to In review in F3 Jun 10, 2025
@Kubuxu Kubuxu force-pushed the feat/f3-cache-changes branch from 14ffdb6 to 87cc522 Compare June 12, 2025 15:09
@Kubuxu Kubuxu changed the title Update go-f3 feat(f3): update go-f3, switch to separate datastore Jun 12, 2025
@Kubuxu Kubuxu marked this pull request as ready for review June 12, 2025 15:11
Copilot AI review requested due to automatic review settings June 12, 2025 15:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the integration with go-f3 by introducing a dedicated F3 datastore (with migration), adjusting DI overrides, cleaning up legacy manifest provider code, and bumping related dependencies.

  • Introduce F3Datastore provider and dtypes.F3DS alias
  • Add migration logic to move data from the metadata store into the new F3 store
  • Remove legacy manifest provider override and related helper code/tests; bump go-f3 and other dependencies

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
node/repo/fsrepo_ds.go Added "f3" to fsDatastores; flagged unused badgerDs helper
node/modules/storage.go New F3Datastore DI provider that returns a separate datastore
node/modules/dtypes/storage.go Defined type F3DS datastore.Batching for F3 data
node/builder_chain.go Override dtypes.F3DS in Fx options; removed manifest override
itests/kit/node_opts.go Removed legacy manifest imports and unsets
itests/f3_test.go, eth_api_f3_test.go Updated test flows to use new config and mock proofs
go.mod Bumped go-f3, x/sync, and pion dependencies
documentation/en/api-v1-unstable-methods.md Removed deprecated response fields (Pause, ExplicitPower, IgnoreECPower)
build/openrpc/full.json Synced OpenRPC spec with removed fields
chain/store/store.go Enhanced error message with contextual values
chain/lf3/f3.go Added migration functions and updated constructor
chain/lf3/participation_lease.go, participation_lease_test.go Changed manifest/Progress signatures; removed nil checks
build/params_shared_funcs.go Removed obsolete passive-testing env var helpers
Comments suppressed due to low confidence (4)

node/modules/storage.go:63

  • [nitpick] The variable mds suggests metadata datastore; consider renaming it to f3ds or ds to reflect its role for F3 data.
mds, err := r.Datastore(ctx, "/f3")

node/modules/dtypes/storage.go:15

  • The comment implies F3DS is namespaced under /f3 in the main repo datastore, but it now uses a separate datastore; please update the comment to reflect the new behavior.
// F3DS stores F3 data. By default it's namespaced under /f3 in main repo datastore.

node/repo/fsrepo_ds.go:22

  • The badgerDs helper and its imports are reported unused; consider removing the unused code and cleaning up imports.
// Helper badgerDs() and its imports are unused

chain/lf3/f3.go:105

  • The code uses xerrors.Errorf but golang.org/x/xerrors is not imported; either add the import or switch to fmt.Errorf.
return xerrors.Errorf("checking if migration complete: %w", err)

@Kubuxu Kubuxu force-pushed the feat/f3-cache-changes branch 2 times, most recently from db25056 to 6fbd5dc Compare June 12, 2025 15:18
@Kubuxu Kubuxu linked an issue Jun 12, 2025 that may be closed by this pull request
@Kubuxu Kubuxu changed the title feat(f3): update go-f3, switch to separate datastore feat(f3): update go-f3 Jun 12, 2025
@Kubuxu Kubuxu changed the title feat(f3): update go-f3 feat(f3): update go-f3, move EC cache to go-f3 Jun 12, 2025
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Jun 12, 2025
@BigLep BigLep linked an issue Jun 13, 2025 that may be closed by this pull request
5 tasks
@Kubuxu Kubuxu force-pushed the feat/f3-cache-changes branch from 6f4b4dc to 53fd1a6 Compare June 16, 2025 13:30
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu Kubuxu force-pushed the feat/f3-cache-changes branch from 53fd1a6 to 7652884 Compare June 16, 2025 13:32
@Kubuxu Kubuxu enabled auto-merge (squash) June 16, 2025 13:33
@Kubuxu Kubuxu merged commit 003c095 into master Jun 16, 2025
52 of 98 checks passed
@Kubuxu Kubuxu deleted the feat/f3-cache-changes branch June 16, 2025 13:37
@github-project-automation github-project-automation bot moved this from In review to Done in F3 Jun 16, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Remove dead f3 code post f3 activation f3 - create a f3 datastore

4 participants