fix(spcli): send SettleDealPayments msg to f05 for lotus-miner actor settle-deal#13142
Merged
fix(spcli): send SettleDealPayments msg to f05 for lotus-miner actor settle-deal#13142
lotus-miner actor settle-deal#13142Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the target actor for the settle-deal message by ensuring the message is sent to the correct market actor address and updates the changelog accordingly.
- Changed the recipient of the SettleDealPayments message from maddr to market.Address.
- Added an import for the market package to support the change.
- Updated the CHANGELOG to document the fix.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/spcli/actor.go | Replaced the to-address using maddr with market.Address and added a new import. |
| CHANGELOG.md | Added an entry to document the fix for sending the SettleDealPayments message. |
Comments suppressed due to low confidence (1)
cli/spcli/actor.go:99
- To maintain consistency with the rest of the file which uses the 'marketactor' alias (e.g., marketactor.Methods.SettleDealPaymentsExported), consider using the same alias (i.e., marketactor.Address) for clarity.
+ To: market.Address,
Closed
11 tasks
… settle-deal` Ref: #13141
rvagg
force-pushed
the
rvagg/settledealpayments
branch
from
46afafa to
38526b9
Compare
rjan90
approved these changes
May 27, 2025
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #13141